[PATCH] D100270: [debug-info] MemCpyOpt should merge the debug location when replace multiple block-local instruction with a new memset

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 11 23:48:30 PDT 2021


djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:488
+    if (!Range.TheStores.empty()) {
+      std::vector<const DILocation *> storeLocs;
+      for (auto storeInst : Range.TheStores) {
----------------
Please use `llvm::SmallVector` instead.

Please use camel naming convention here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100270/new/

https://reviews.llvm.org/D100270



More information about the llvm-commits mailing list