[PATCH] D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.value at O2

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D97673#2680725 <https://reviews.llvm.org/D97673#2680725>, @lxfind wrote:

> I am also a bit skeptical about this patch.
> Specifically I agree that dbg info should not affect the coroutine frame.
> From what I can tell, dbg intrinsics are location insensitive, i.e. they can be put at any location. (correct me if I am wrong)
> So a use of any value by dbg intrinsics should not cause the value to be put on the frame.
> Perhaps we could first move all dbg intrinsics to a dedicated location (e.g. right after corobegin) before creating the frame, and copy them during function cloning?

It looks better to collect the dbg.values who wouldn't change the layout of the frame. I would try to make it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97673/new/

https://reviews.llvm.org/D97673