[PATCH] D100229: [lld-macho] Make load relaxation work for arm64_32

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/test/MachO/arm64-32-reloc-got-load.s:1
+# REQUIRES: aarch64
+
----------------
gkm wrote:
> Super nitty: this and the original `arm64-reloc-got-load.s` have some tabs, and even some whitespace only differences between them.
> 
> For that matter, these 16 test files have some tabs:
> ```
> ./x86-64-reloc-got-load.s
> ./why-load.s
> ./arm64-relocs.s
> ./arm64-reloc-pointer-to-got.s
> ./weak-reference.s
> ./objc.s
> ./invalid/bad-got-to-dylib-tlv-reference.s
> ./invalid/bad-tlv-def.s
> ./invalid/bad-tlv-opcode.s
> ./weak-binding.s
> ./indirect-symtab.s
> ./tlv-dylib.s
> ./arm64-32-reloc-got-load.s
> ./mattrs.ll
> ./arm64-reloc-got-load.s
> ./tlv.s
> ```
good point. I've cleaned up the rest here: https://github.com/llvm/llvm-project/commit/74283fc8534b729f5e15ae934de15c01fd6db9c0


================
Comment at: lld/test/MachO/arm64-32-reloc-got-load.s:27
+# DYLIB-NEXT:  adrp	x8, [[#]] ; 0x[[#%x,GOT:]]
+# DYLIB-NEXT:  ldr	w8, [x8, #4]
+# DYLIB-NEXT:  adrp	x8, [[#]] ; 0x[[#GOT]]
----------------
gkm wrote:
> The original `arm64-reloc-got-load.s` had this comment appended to the line: `; literal pool symbol address: _foo`
unfortunately llvm-objdump doesn't emit those comments for arm64_32


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100229/new/

https://reviews.llvm.org/D100229