[PATCH] D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:192
+  if (dirContext_.size() >= 1) {
+    CheckSIMDNest(x);
+  }
----------------
Can you check for the SIMD construct before calling this function?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:313
+  // TODO: Check for declare simd regions.
+  bool eligibleSIMD = false;
+  if (llvm::omp::simdSet.test(GetContext().directive)) {
----------------
Nit: use braced initializer.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:314
+  bool eligibleSIMD = false;
+  if (llvm::omp::simdSet.test(GetContext().directive)) {
+    std::visit(Fortran::common::visitors{
----------------
Will simd be always the parent construct? Are there cases where it can become an ancestor but not the immediate parent?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99757/new/

https://reviews.llvm.org/D99757