[llvm] 91248e2 - [InstCombine] Improve "get low bit mask upto and including bit X" pattern
Roman Lebedev via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 11 08:08:56 PDT 2021
Author: Roman Lebedev
Date: 2021-04-11T18:08:08+03:00
New Revision: 91248e2db93a896a374098703567b0b1c8b1ad86
URL: https://github.com/llvm/llvm-project/commit/91248e2db93a896a374098703567b0b1c8b1ad86
DIFF: https://github.com/llvm/llvm-project/commit/91248e2db93a896a374098703567b0b1c8b1ad86.diff
LOG: [InstCombine] Improve "get low bit mask upto and including bit X" pattern
https://alive2.llvm.org/ce/z/3u-48R
Added:
Modified:
llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
llvm/test/Transforms/InstCombine/get-lowbitmask-upto-and-including-bit.ll
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
index 6bb0627c40a8..8c0d796ef1c9 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
@@ -2843,6 +2843,17 @@ Instruction *InstCombinerImpl::visitOr(BinaryOperator &I) {
if (sinkNotIntoOtherHandOfAndOrOr(I))
return &I;
+ // Improve "get low bit mask up to and including bit X" pattern:
+ // (1 << X) | ((1 << X) + -1) --> -1 l>> (bitwidth(x) - 1 - X)
+ if (match(&I, m_c_Or(m_Add(m_Shl(m_One(), m_Value(X)), m_AllOnes()),
+ m_Shl(m_One(), m_Deferred(X)))) &&
+ match(&I, m_c_Or(m_OneUse(m_Value()), m_Value()))) {
+ Type *Ty = X->getType();
+ Value *Sub = Builder.CreateSub(
+ ConstantInt::get(Ty, Ty->getScalarSizeInBits() - 1), X);
+ return BinaryOperator::CreateLShr(Constant::getAllOnesValue(Ty), Sub);
+ }
+
// An or recurrence w/loop invariant step is equivelent to (or start, step)
PHINode *PN = nullptr;
Value *Start = nullptr, *Step = nullptr;
diff --git a/llvm/test/Transforms/InstCombine/get-lowbitmask-upto-and-including-bit.ll b/llvm/test/Transforms/InstCombine/get-lowbitmask-upto-and-including-bit.ll
index 88ba54a930d0..1365a109e71f 100644
--- a/llvm/test/Transforms/InstCombine/get-lowbitmask-upto-and-including-bit.ll
+++ b/llvm/test/Transforms/InstCombine/get-lowbitmask-upto-and-including-bit.ll
@@ -6,9 +6,8 @@ declare void @use8(i8)
; Basic test
define i8 @t0(i8 %x) {
; CHECK-LABEL: @t0(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl i8 1, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i8 [[BITMASK]], -1
-; CHECK-NEXT: [[MASK:%.*]] = or i8 [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i8 7, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i8 -1, [[TMP1]]
; CHECK-NEXT: ret i8 [[MASK]]
;
%bitmask = shl i8 1, %x
@@ -20,9 +19,8 @@ define i8 @t0(i8 %x) {
; Same, but
diff erent bit width
define i16 @t1(i16 %x) {
; CHECK-LABEL: @t1(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl i16 1, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i16 [[BITMASK]], -1
-; CHECK-NEXT: [[MASK:%.*]] = or i16 [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i16 15, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i16 -1, [[TMP1]]
; CHECK-NEXT: ret i16 [[MASK]]
;
%bitmask = shl i16 1, %x
@@ -34,9 +32,8 @@ define i16 @t1(i16 %x) {
; Vectors
define <2 x i8> @t2_vec(<2 x i8> %x) {
; CHECK-LABEL: @t2_vec(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl <2 x i8> <i8 1, i8 1>, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add <2 x i8> [[BITMASK]], <i8 -1, i8 -1>
-; CHECK-NEXT: [[MASK:%.*]] = or <2 x i8> [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub <2 x i8> <i8 7, i8 7>, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr <2 x i8> <i8 -1, i8 -1>, [[TMP1]]
; CHECK-NEXT: ret <2 x i8> [[MASK]]
;
%bitmask = shl <2 x i8> <i8 1, i8 1>, %x
@@ -46,9 +43,8 @@ define <2 x i8> @t2_vec(<2 x i8> %x) {
}
define <3 x i8> @t3_vec_undef0(<3 x i8> %x) {
; CHECK-LABEL: @t3_vec_undef0(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl <3 x i8> <i8 1, i8 undef, i8 1>, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add <3 x i8> [[BITMASK]], <i8 -1, i8 -1, i8 -1>
-; CHECK-NEXT: [[MASK:%.*]] = or <3 x i8> [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub <3 x i8> <i8 7, i8 7, i8 7>, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr <3 x i8> <i8 -1, i8 -1, i8 -1>, [[TMP1]]
; CHECK-NEXT: ret <3 x i8> [[MASK]]
;
%bitmask = shl <3 x i8> <i8 1, i8 undef, i8 1>, %x
@@ -58,9 +54,8 @@ define <3 x i8> @t3_vec_undef0(<3 x i8> %x) {
}
define <3 x i8> @t4_vec_undef1(<3 x i8> %x) {
; CHECK-LABEL: @t4_vec_undef1(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl <3 x i8> <i8 1, i8 1, i8 1>, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add <3 x i8> [[BITMASK]], <i8 -1, i8 undef, i8 -1>
-; CHECK-NEXT: [[MASK:%.*]] = or <3 x i8> [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub <3 x i8> <i8 7, i8 7, i8 7>, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr <3 x i8> <i8 -1, i8 -1, i8 -1>, [[TMP1]]
; CHECK-NEXT: ret <3 x i8> [[MASK]]
;
%bitmask = shl <3 x i8> <i8 1, i8 1, i8 1>, %x
@@ -70,9 +65,8 @@ define <3 x i8> @t4_vec_undef1(<3 x i8> %x) {
}
define <3 x i8> @t5_vec_undef2(<3 x i8> %x) {
; CHECK-LABEL: @t5_vec_undef2(
-; CHECK-NEXT: [[BITMASK:%.*]] = shl <3 x i8> <i8 1, i8 1, i8 undef>, [[X:%.*]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add <3 x i8> [[BITMASK]], <i8 -1, i8 undef, i8 -1>
-; CHECK-NEXT: [[MASK:%.*]] = or <3 x i8> [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub <3 x i8> <i8 7, i8 7, i8 7>, [[X:%.*]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr <3 x i8> <i8 -1, i8 -1, i8 -1>, [[TMP1]]
; CHECK-NEXT: ret <3 x i8> [[MASK]]
;
%bitmask = shl <3 x i8> <i8 1, i8 1, i8 undef>, %x
@@ -86,8 +80,8 @@ define i8 @t6_extrause0(i8 %x) {
; CHECK-LABEL: @t6_extrause0(
; CHECK-NEXT: [[BITMASK:%.*]] = shl i8 1, [[X:%.*]]
; CHECK-NEXT: call void @use8(i8 [[BITMASK]])
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i8 [[BITMASK]], -1
-; CHECK-NEXT: [[MASK:%.*]] = or i8 [[LOWBITMASK]], [[BITMASK]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i8 7, [[X]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i8 -1, [[TMP1]]
; CHECK-NEXT: ret i8 [[MASK]]
;
%bitmask = shl i8 1, %x
@@ -148,9 +142,8 @@ define i8 @t10_nocse_extrause0(i8 %x) {
; CHECK-LABEL: @t10_nocse_extrause0(
; CHECK-NEXT: [[BITMASK0:%.*]] = shl i8 1, [[X:%.*]]
; CHECK-NEXT: call void @use8(i8 [[BITMASK0]])
-; CHECK-NEXT: [[BITMASK1:%.*]] = shl i8 1, [[X]]
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i8 [[BITMASK0]], -1
-; CHECK-NEXT: [[MASK:%.*]] = or i8 [[LOWBITMASK]], [[BITMASK1]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i8 7, [[X]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i8 -1, [[TMP1]]
; CHECK-NEXT: ret i8 [[MASK]]
;
%bitmask0 = shl i8 1, %x
@@ -198,8 +191,8 @@ define i8 @t13_nocse_extrause3(i8 %x) {
; CHECK-NEXT: call void @use8(i8 [[BITMASK0]])
; CHECK-NEXT: [[BITMASK1:%.*]] = shl i8 1, [[X]]
; CHECK-NEXT: call void @use8(i8 [[BITMASK1]])
-; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i8 [[BITMASK0]], -1
-; CHECK-NEXT: [[MASK:%.*]] = or i8 [[LOWBITMASK]], [[BITMASK1]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i8 7, [[X]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i8 -1, [[TMP1]]
; CHECK-NEXT: ret i8 [[MASK]]
;
%bitmask0 = shl i8 1, %x
@@ -214,10 +207,10 @@ define i8 @t14_nocse_extrause4(i8 %x) {
; CHECK-LABEL: @t14_nocse_extrause4(
; CHECK-NEXT: [[BITMASK0:%.*]] = shl i8 1, [[X:%.*]]
; CHECK-NEXT: call void @use8(i8 [[BITMASK0]])
-; CHECK-NEXT: [[BITMASK1:%.*]] = shl i8 1, [[X]]
; CHECK-NEXT: [[LOWBITMASK:%.*]] = add i8 [[BITMASK0]], -1
; CHECK-NEXT: call void @use8(i8 [[LOWBITMASK]])
-; CHECK-NEXT: [[MASK:%.*]] = or i8 [[LOWBITMASK]], [[BITMASK1]]
+; CHECK-NEXT: [[TMP1:%.*]] = sub i8 7, [[X]]
+; CHECK-NEXT: [[MASK:%.*]] = lshr i8 -1, [[TMP1]]
; CHECK-NEXT: ret i8 [[MASK]]
;
%bitmask0 = shl i8 1, %x
More information about the llvm-commits
mailing list