[PATCH] D100253: [TableGen] Resolve concrete but not complete field access initializers

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 10 20:08:53 PDT 2021


dsanders added inline comments.


================
Comment at: llvm/lib/TableGen/Record.cpp:658
 
+bool ListInit::isComplete() const {
+  for (Init *Element : *this) {
----------------
One thing to mention about this function. Downstream, our test for this uses our !iscomplete() predicate but I'm not aware of a good way to test this upstream as the FieldInit::Fold change means it no longer controls whether FieldInit's successfully resolve.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100253/new/

https://reviews.llvm.org/D100253



More information about the llvm-commits mailing list