[PATCH] D100119: [mlir] Rename AVX512 dialect to X86Vector

Sat Apr 10 12:02:50 PDT 2021

ftynse added a comment.

In D100119#2681022 <https://reviews.llvm.org/D100119#2681022>, @bondhugula wrote:

> Is there a proposal for the first non AVX op to be added to this and which one it would be?

There is a patch, D99818 <https://reviews.llvm.org/D99818>, which triggered the discussion about renaming. That patch adds an AVX op. I am highly supportive of renaming the dialect in a separate patch.

> I also see @ftynse suggested going with AVX there.

You must be misreading, I did not suggest this. This will be equally confusing to have AVX512 ops in the AVX dialect and AVX ops in the AVX512 dialect; these are two different instruction sets.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100119/new/

https://reviews.llvm.org/D100119