[PATCH] D100203: [TTI] NFC: Change getCmpSelInstrCost to return InstructionCost

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:2041
     // So just need a single extractelement.
-    return ShuffleCost + MinMaxCost +
+    return ShuffleCost + *MinMaxCost.getValue() +
            thisT()->getVectorInstrCost(Instruction::ExtractElement, Ty, 0);
----------------
This doesn't need the getValue() now, I think?


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1272
 
-  return LegalizationCost + /*Cost of horizontal reduction*/ 2;
+  return *LegalizationCost.getValue() + /*Cost of horizontal reduction*/ 2;
 }
----------------
This too.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:165
   unsigned NumLoads = VTy->getNumElements();
-  InstructionCost MemOpCost =
+  unsigned MemOpCost =
       getMemoryOpCost(Opcode, VTy->getElementType(), Alignment, 0, CostKind, I);
----------------
Merge gone off?


================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:3723
+                         CmpInst::BAD_ICMP_PREDICATE, CostKind);
+  return *Result.getValue();
 }
----------------
This one was already converted to an InstructionCost too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100203/new/

https://reviews.llvm.org/D100203