[PATCH] D100229: [lld-macho] Make load relaxation work for arm64_32

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a subscriber: kristof.beyls.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

arm64_32 uses 32-bit GOT loads, so we should accept those
instructions in `ARM64Common::relaxGotLoad()` too.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100229

Files:
  lld/MachO/Arch/ARM64Common.cpp
  lld/test/MachO/arm64-32-reloc-got-load.s


Index: lld/test/MachO/arm64-32-reloc-got-load.s
===================================================================
--- /dev/null
+++ lld/test/MachO/arm64-32-reloc-got-load.s
@@ -0,0 +1,48 @@
+# REQUIRES: aarch64
+
+# RUN: rm -rf %t; split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple=arm64_32-apple-darwin %t/main.s -o %t/main.o
+# RUN: llvm-mc -filetype=obj -triple=arm64_32-apple-darwin %t/foobar.s -o %t/foobar.o
+
+# RUN: %lld-watchos -lSystem -arch arm64_32 -o %t/static %t/main.o %t/foobar.o
+# RUN: llvm-objdump --macho -d --no-show-raw-insn --syms %t/static | FileCheck %s --check-prefix=STATIC
+
+# RUN: %lld-watchos -lSystem -arch arm64_32 -dylib -o %t/libfoo.dylib %t/foobar.o
+# RUN: %lld-watchos -lSystem -arch arm64_32 -o %t/main %t/main.o %t/libfoo.dylib
+# RUN: llvm-objdump --macho -d --no-show-raw-insn --section-headers %t/main | FileCheck %s --check-prefix=DYLIB
+
+# STATIC-LABEL: _main:
+# STATIC-NEXT:  adrp x8, [[#]] ; 0x[[#%x,PAGE:]]
+# STATIC-NEXT:  add	 x8, x8, #[[#%u,FOO_OFF:]]
+# STATIC-NEXT:  adrp x8, [[#]] ; 0x[[#PAGE]]
+# STATIC-NEXT:  add	 x8, x8, #[[#%u,BAR_OFF:]]
+# STATIC-NEXT:  ret
+
+# STATIC-LABEL: SYMBOL TABLE:
+# STATIC-DAG:   {{0*}}[[#%x,PAGE+FOO_OFF]] g     F __TEXT,__text _foo
+# STATIC-DAG:   {{0*}}[[#%x,PAGE+BAR_OFF]] g     F __TEXT,__text _bar
+
+# DYLIB-LABEL: _main:
+# DYLIB-NEXT:  adrp	x8, [[#]] ; 0x[[#%x,GOT:]]
+# DYLIB-NEXT:  ldr	w8, [x8, #4]
+# DYLIB-NEXT:  adrp	x8, [[#]] ; 0x[[#GOT]]
+# DYLIB-NEXT:  ldr	w8, [x8]
+# DYLIB-NEXT:  ret
+# DYLIB-NEXT:  Sections:
+# DYLIB-NEXT:  Idx   Name   Size      VMA            Type
+# DYLIB:       [[#]] __got  00000008  [[#%.8x,GOT]]  DATA
+
+#--- main.s
+.globl _main, _foo, _bar
+.p2align 2
+_main:
+	adrp x8, _foo at GOTPAGE
+	ldr	 w8, [x8, _foo at GOTPAGEOFF]
+	adrp x8, _bar at GOTPAGE
+	ldr	 w8, [x8, _bar at GOTPAGEOFF]
+  ret
+
+#--- foobar.s
+.globl _foo, _bar
+_foo:
+_bar:
Index: lld/MachO/Arch/ARM64Common.cpp
===================================================================
--- lld/MachO/Arch/ARM64Common.cpp
+++ lld/MachO/Arch/ARM64Common.cpp
@@ -98,8 +98,9 @@
   // ARM DDI 0487G.a (ID011921)
   uint32_t instruction = read32le(loc);
   // C6.2.132 LDR (immediate)
-  // LDR <Xt>, [<Xn|SP>{, #<pimm>}]
-  if ((instruction & 0xffc00000) != 0xf9400000)
+  // This matches both the 64- and 32-bit variants:
+  // LDR <(X|W)t>, [<Xn|SP>{, #<pimm>}]
+  if ((instruction & 0xbfc00000) != 0xb9400000)
     error(getRelocAttrs(type).name + " reloc requires LDR instruction");
   assert(((instruction >> 10) & 0xfff) == 0 &&
          "non-zero embedded LDR immediate");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100229.336558.patch
Type: text/x-patch
Size: 2573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210409/033ca5b4/attachment.bin>