[PATCH] D100159: Support: Add move semantics to mapped_file_region
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 9 13:40:16 PDT 2021
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks great!
================
Comment at: llvm/include/llvm/Support/FileSystem.h:1289-1291
+
+ mapped_file_region(const mapped_file_region &) = delete;
+ mapped_file_region &operator=(const mapped_file_region &) = delete;
----------------
This is the default/doesn't need to be written, since the type has user-declared move ops, so they could be omitted - but don't mind if you prefer to have them here for documentation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100159/new/
https://reviews.llvm.org/D100159
More information about the llvm-commits
mailing list