[llvm] 5bca7cd - Add correct types to the xxsplti32dx pattern.

[Stefan Pintilie via llvm-commits]

Author: Stefan Pintilie
Date: 2021-04-09T14:11:34-05:00
New Revision: 5bca7cdafb897f2e8d50dd117bac7e7a663397ce

URL: https://github.com/llvm/llvm-project/commit/5bca7cdafb897f2e8d50dd117bac7e7a663397ce
DIFF: https://github.com/llvm/llvm-project/commit/5bca7cdafb897f2e8d50dd117bac7e7a663397ce.diff

LOG: Add correct types to the xxsplti32dx pattern.

Regiser types for xxsplti32dx for two td file patterns was incorrect.
Fixed the two types and added a test case that was reduced from a larger
failing test.

Reviewed By: nemanjai, #powerpc

Differential Revision: https://reviews.llvm.org/D100223

Added: 
    llvm/test/CodeGen/PowerPC/ppc64-xxsplti32dx-pattern-check.ll

Modified: 
    llvm/lib/Target/PowerPC/PPCInstrPrefix.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/PowerPC/PPCInstrPrefix.td b/llvm/lib/Target/PowerPC/PPCInstrPrefix.td
index 9a6631c085550..a374c5f1c6565 100644
--- a/llvm/lib/Target/PowerPC/PPCInstrPrefix.td
+++ b/llvm/lib/Target/PowerPC/PPCInstrPrefix.td
@@ -2633,13 +2633,13 @@ def : Pat<(f32 nzFPImmAsi64:$A),
           (COPY_TO_REGCLASS (XXSPLTI32DX (XXSPLTI32DX(IMPLICIT_DEF), 0,
                                         (getFPAs64BitIntHi $A)),
                                         1, (getFPAs64BitIntLo $A)),
-                            VSRC)>;
+                            VSSRC)>;
 
 def : Pat<(f64 nzFPImmAsi64:$A),
           (COPY_TO_REGCLASS (XXSPLTI32DX (XXSPLTI32DX (IMPLICIT_DEF), 0,
                                         (getFPAs64BitIntHi $A)),
                                         1, (getFPAs64BitIntLo $A)),
-                            VSRC)>;
+                            VSFRC)>;
 
   // Anonymous patterns for XXEVAL
   // AND

diff  --git a/llvm/test/CodeGen/PowerPC/ppc64-xxsplti32dx-pattern-check.ll b/llvm/test/CodeGen/PowerPC/ppc64-xxsplti32dx-pattern-check.ll
new file mode 100644
index 0000000000000..b7f5b4581f767
--- /dev/null
+++ b/llvm/test/CodeGen/PowerPC/ppc64-xxsplti32dx-pattern-check.ll
@@ -0,0 +1,41 @@
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-- \
+; RUN:   -mcpu=pwr10 -ppc-asm-full-reg-names < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mtriple=powerpc64-- \
+; RUN:   -mcpu=pwr10 -ppc-asm-full-reg-names < %s | FileCheck %s
+
+; CHECK-NOT: Impossible reg-to-reg copy
+; CHECK-LABEL: test_xxsplti32dx
+; CHECK:         xxsplti32dx
+
+;; Test reduced from larger application where bug was initially detected.
+;; This test checks that the correct register class is used for xxsplti32dx.
+
+declare dso_local void @callee() local_unnamed_addr
+
+define dso_local void @test_xxsplti32dx() local_unnamed_addr {
+entry:
+  %i1 = load double, double* undef, align 8
+  br label %for.body124
+
+for.body124:
+  %E0 = phi double [ 0.000000e+00, %entry ], [ %E1, %for.end1072 ]
+  br i1 undef, label %for.body919.preheader, label %for.end1072
+
+for.body919.preheader:
+  %i4 = load double, double* null, align 8
+  %i5 = load double, double* null, align 8
+  %i15 = insertelement <2 x double> poison, double %i5, i32 0
+  %i23 = insertelement <2 x double> undef, double %i4, i32 1
+  %i24 = insertelement <2 x double> %i15, double 0x3FC5555555555555, i32 1
+  %i25 = fmul fast <2 x double> %i23, %i24
+  %mul986 = extractelement <2 x double> %i25, i32 1
+  %sub994 = fsub fast double %E0, %mul986
+  br label %for.end1072
+
+for.end1072:
+  %E1 = phi double [ %E0, %for.body124 ], [ %sub994, %for.body919.preheader ]
+  %i28 = phi <2 x double> [ zeroinitializer, %for.body124 ], [ %i15, %for.body919.preheader ]
+  tail call void @callee()
+  store <2 x double> %i28, <2 x double>* undef, align 8
+  br label %for.body124
+}