[PATCH] D100130: [SystemZ][z/OS][Windows] Add new functions that set Text/Binary mode for Stdin and Stdout based on OpenFlags

[Abhina Sree via Phabricator via llvm-commits]

abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/lib/Support/raw_ostream.cpp:578
+    // Change stdout's text/binary mode based on the Flags.
+    sys::ChangeStdoutMode(Flags);
     return STDOUT_FILENO;
----------------
anirudhp wrote:
> We are foregoing the check for the code returned by here. Is this okay? Should we be complete and assign it to EC? On unix this shouldn't matter because it just returns std::error_code (which is already what EC is). However, Windows seems to be different.
I think it's ok, we didn't check the return code in the old version either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100130/new/

https://reviews.llvm.org/D100130