[PATCH] D100199: [TTI] NFC: Change getCastInstrCost and getExtractWithExtendCost to return InstructionCost

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 9 09:31:55 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:870
       // the operation will get scalarized.
-      unsigned Num = cast<FixedVectorType>(DstVTy)->getNumElements();
-      unsigned Cost = thisT()->getCastInstrCost(
+      InstructionCost Num = cast<FixedVectorType>(DstVTy)->getNumElements();
+      InstructionCost Cost = thisT()->getCastInstrCost(
----------------
dmgreen wrote:
> Should this be a cost?
It should not, good spot!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100199/new/

https://reviews.llvm.org/D100199



More information about the llvm-commits mailing list