[PATCH] D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 9 08:43:49 PDT 2021


ABataev added inline comments.


================
Comment at: clang/include/clang/Basic/OpenMPKinds.h:173
+#include "clang/Basic/OpenMPKinds.def"
+  OMPC_ADJUST_ARGS_unknown
+};
----------------
`OMPC_ADJUST_ARGS_unknown,`?


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7073-7074
+    FunctionDecl *FD, Expr *VariantRef, OMPTraitInfo &TI,
+    MutableArrayRef<Expr *> AdjustArgsNothing,
+    MutableArrayRef<Expr *> AdjustArgsNeedDevicePtr, SourceRange SR) {
+
----------------
Why `MutableArrayRef`, not just `ArrayRef`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99905/new/

https://reviews.llvm.org/D99905



More information about the llvm-commits mailing list