[PATCH] D100116: Reuse temporary files for print-changed=diff.

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 9 08:34:23 PDT 2021


jamieschmeiser added a comment.

I suspect it may have something to do with name collisions in the calls to create a unique file name.  It says that it loops a set number of times trying permutations and I think it just runs out of permutations, partly because the name doesn't have special characters allowing extra permutations.  The uses of the file cannot collide (unless the pass manager becomes multi-threaded) so static solves the problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100116/new/

https://reviews.llvm.org/D100116



More information about the llvm-commits mailing list