[PATCH] D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 9 08:22:51 PDT 2021


StephenTozer updated this revision to Diff 336473.
StephenTozer added a comment.

Replace shared_ptr usage with raw pointers, as neither a copy constructor nor the destructor for SDDbgValue are ever called, making memory management a non-issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99423/new/

https://reviews.llvm.org/D99423

Files:
  llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
  llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/test/CodeGen/X86/dbg-list-dependencies.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99423.336473.patch
Type: text/x-patch
Size: 23181 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210409/634d1b36/attachment.bin>


More information about the llvm-commits mailing list