[PATCH] D100015: [debug-info] make fortran CHARACTER(1) type as valid unsigned type

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/CodeGen/Generic/pr49872.ll:1
+; RUN: llc < %s | FileCheck %s
+
----------------
wouldn't you want to pipe this through dwarfdump or emit assembler output?


================
Comment at: llvm/test/CodeGen/Generic/pr49872.ll:4
+; PR49872
+; Check a interger constant for Fortran CHARACTER(1) will not cause a crash in
+; DebugHandlerBase::isUnsignedDIType when calling DwarfUnit::addConstantValue
----------------
integer


================
Comment at: llvm/test/CodeGen/Generic/pr49872.ll:7
+
+; CHECK-LABEL: s1_after_sroa
+
----------------
Could we check anything slightly more substantial here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100015/new/

https://reviews.llvm.org/D100015