[PATCH] D100069: Disable use of SCC bit from asm

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 7 15:17:45 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4099
+    S = SMLoc::getFromPointer(&CStr.data()[CStr.find("scc")]);
+    Error(S, "scc is not supported on this GPU");
+    return false;
----------------
t-tye wrote:
> Could the GPU name be printed? I think that is done in other error messages?
Asm parser universally prints "on this GPU". If we want to be specific we probably need to update it everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100069/new/

https://reviews.llvm.org/D100069



More information about the llvm-commits mailing list