[PATCH] D100069: Disable use of SCC bit from asm

Wed Apr 7 14:16:09 PDT 2021

rampitec added a comment.

In D100069#2675145 <https://reviews.llvm.org/D100069#2675145>, @arsenm wrote:

> Message / name is somewhat confusing since I assumed this meant the scc register

Retitled.

================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4097-4098
+    SMLoc S = getImmLoc(AMDGPUOperand::ImmTyCPol, Operands);
+    StringRef CStr(S.getPointer());
+    S = SMLoc::getFromPointer(&CStr.data()[CStr.find("scc")]);
+    Error(S, "scc is not supported on this GPU");
----------------
arsenm wrote:
> I don't think this should be using SMLoc to check the string content. Isn't there an already parsed token?
Not since I did a function to parse all these bits together and  in any order. I now have to search for it. Anyhow, it is just moved from the place below.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100069/new/

https://reviews.llvm.org/D100069