[PATCH] D64830: [Xtensa 4/10] Add basic *td files with Xtensa architecture description.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/XtensaInstrFormats.td:166
+
+
+  let Inst{23-12} = imm12;
----------------
craig.topper wrote:
> Drop the second blank line?
Corrected


================
Comment at: llvm/lib/Target/Xtensa/XtensaRegisterInfo.td:30
+class ARReg<bits<4> num, string n, list<string> alt = []> : XtensaReg<n> {
+    let HWEncoding{3-0} = num;
+    let AltNames = alt;
----------------
craig.topper wrote:
> This is overindented relative to the style of the rest of the file.
Corrected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64830/new/

https://reviews.llvm.org/D64830