[PATCH] D98136: [RISCV][RFC] Initially support the K-extension instructions on the LLVM MC layer

[Jim Lin via Phabricator via llvm-commits]

Jim added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:190
                               "'Zvamo'(Vector AMO Operations)">;
-
+def FeatureExtZkb
+    : SubtargetFeature<"experimental-zkb", "HasStdExtZkb", "true",
----------------
Add blank line


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:192
+    : SubtargetFeature<"experimental-zkb", "HasStdExtZkb", "true",
+                       "'Zkb'(Bitmanip subset included in the scalar cryptography extension)",
+                       [FeatureExtZbp]>;
----------------
and others


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:222
+                       FeatureExtZkg,
+                       FeatureExtZkb]>;
+def HasStdExtZks : Predicate<"Subtarget->hasStdExtZks()">,
----------------
Alignment


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:251
+                       FeatureExtZkg,
+                       FeatureExtZkb]>;
+def HasStdExtZkn : Predicate<"Subtarget->hasStdExtZkn()">,
----------------
Alignment


================
Comment at: llvm/lib/Target/RISCV/RISCV.td:268
+                           AssemblerPredicate<(all_of FeatureStdExtK),
+                           "'K' (Scalar Cryptography Instructions)">;
 def Feature64Bit
----------------
Add blank line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98136/new/

https://reviews.llvm.org/D98136