[PATCH] D98101: [RISCV] Enable the LocalStackSlotAllocation pass support

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 22:02:30 PDT 2021


StephenFan added a comment.

In D98101#2663432 <https://reviews.llvm.org/D98101#2663432>, @asb wrote:

> Could you please rebase this to account for D98716 <https://reviews.llvm.org/D98716>?
>
> I _think_ the right fix is to change the call for `needsStackRealignment` to `shouldRealignStack`. But I'm seeing multiple runtime failures for the GCC torture suite with the patch applied. e.g. 20031012-1.c at O0 for rv32imafdc ilp32.

Hi @asb . I wrote a script to compile and run the gcc c torture tests on qemu. According to the test result and as you said, multiple runtime failures appeared. However, 20031012-1.c at O0 for rv32imafdc ilp32 didn't fail on qemu. And I have fixed the failures and updated the patch. Can you help me testing the gcc c torture test again? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98101/new/

https://reviews.llvm.org/D98101



More information about the llvm-commits mailing list