[PATCH] D99754: [LLD][ELF][AVR] Propagate ELF flags to the linked image

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 20:39:36 PDT 2021


MaskRay added a comment.

llvm/BinaryFormat/ELF.h is typically added along with tests to llvm-readobj/yaml2obj/obj2yaml. See D95728 <https://reviews.llvm.org/D95728> for an example.



================
Comment at: lld/ELF/Arch/AVR.cpp:213
+    uint32_t objFlags = getEFlags(f);
+
+    if ((objFlags & EF_AVR_ARCH_MASK) != (flags & EF_AVR_ARCH_MASK))
----------------
The code style does not tend to insert so many empty lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99754/new/

https://reviews.llvm.org/D99754



More information about the llvm-commits mailing list