[PATCH] D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.value at O2

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D97673#2677198 <https://reviews.llvm.org/D97673#2677198>, @aprantl wrote:

> I would recommend to pick a name for `-enhance-debug-with-coroutine ` that does not contain `debug`. The name should make clear that this changes codegen, so nobody gets the idea of turning it as part of a -g option. For example, something like `-coroutine-spill-all-locals`.

The accurate semantic for this option is collect values used by dbg.values, which would make coroutine frame get larger in some cases. This option would work only if user turns -g on. The name `-coroutine-spill-all-locals` is not correct and it is hard for me to get a name which shows it would change the codegen and enhance the debugbility. I am wondering if we can remove this option and make collecting values used by dbg.values a default behavior. From our analysis above, it should be unusual to make the coroutine frame larger. @lxfind what's your opinion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97673/new/

https://reviews.llvm.org/D97673