[PATCH] D100085: [X86] Support -march=rocketlake

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86.td:271-273
-def FeatureSGX     : SubtargetFeature<"sgx", "HasSGX", "true",
-                                      "Enable Software Guard Extensions">;
 def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt", "HasCLFLUSHOPT", "true",
----------------
craig.topper wrote:
> Clang still puts it in target-features attribute so you can’t delete this or you’ll get a warning that the feature doesn’t exist.
If you delete the definition of FeatureSGX, you need to remove the related code in X86Subtarget.h too.  BTW, I don't think "there are no IR intrinsics for a feature" is a good reason to remove a feature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100085/new/

https://reviews.llvm.org/D100085