[PATCH] D100159: Support: Allow mapped_file_region to be used in an Optional

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

looks like the underlying mapped_file_region could be made movable without the overhead of Optional (both the Windows and Unix dtors of mapped_file_region test whether the mapping is non-null, so a move ctor can null out the Mapping member to ensure no double-closing, etc) which might be nicer (avoiding the Optional overhead)/more general?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100159/new/

https://reviews.llvm.org/D100159