[PATCH] D99769: [funcattrs] Infer nosync from instruction walk

[Stefan Stipanovic via Phabricator via llvm-commits]

sstefan1 added a comment.

In D99769#2676275 <https://reviews.llvm.org/D99769#2676275>, @fhahn wrote:

> In D99769#2676226 <https://reviews.llvm.org/D99769#2676226>, @sstefan1 wrote:
>
>> I'm doing some testing with a lightweight attributor enabled by default. Can this wait few more days, until I get some results? If the numbers are good, maybe we won't need this after all?
>
> That's great, but I think 'using a lightweight attributor pass by default' requires at least the following steps 1) add the pass with option to enable it, 2) have people test it, 3) collect data to make a convincing case for enabling it, 4) flip the default and deal with the fallout. I am not sure this can be done in a few days.
>
> I'd recommend to start with sharing a patch that adds this lightweight attributor pass, so we can start with getting consensus what the scope of this pass should be and go from there (without tying ourselves to any particular timeframe)

Sounds good to me. I agree it is better not to rush things.

Just for clarification: a lightweight attributor wouldn't be a separate pass, but a regular attributor pass just with fewer abstract attributes initialised by default. I'll start with that and we'll see how it goes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99769/new/

https://reviews.llvm.org/D99769