[PATCH] D99406: RFC [lit] Detect if processes to execute are MSys based, apply custom quoting logic

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

FWIW, see https://github.com/msys2/msys2-runtime/issues/36#issuecomment-815692656 - Git for Windows has got a check/heuristic for whether a tool to execute is an msys based one, and use a different quoting algorithm for that case, which supports the notion that arguments need to be quoted differently for msys based tools. We've been lucky so far, and with D99938 <https://reviews.llvm.org/D99938> it seems that we can postpone that issue a bit further.

There's an unmerged patch for upstream cygwin that is supposed to make the argument parsing standards compliant (I haven't tested it myself yet), but as Johannes pointed out in that msys2-runtime issue, fixing the argument parsing properly breaks things for everybody who so far have had to work around the issue, as they quote things in a nonstandard way for the current msys parser. (That also is an argument against going with this patch - if we can avoid doing standards-incompliant special quoting for msys, we've got an easier situation if they fix their behaviour in the future too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99406/new/

https://reviews.llvm.org/D99406