[PATCH] D99977: [GVN] Properly invalidate ICF cache when we simplify a value

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 12:45:55 PDT 2021


rnk accepted this revision.
rnk added a comment.

lgtm



================
Comment at: llvm/include/llvm/Analysis/InstructionPrecedenceTracking.h:83
 
+  /// Notifies this tracking that we are going to remove all uses of \p Inst.
+  /// It makes all necessary updates to internal caches to keep them consistent.
----------------
s/remove/replace/, should be "... going to replace all uses of..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99977/new/

https://reviews.llvm.org/D99977



More information about the llvm-commits mailing list