[PATCH] D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 12:14:56 PDT 2021


thegameg added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocGreedy.cpp:3172
+      if (isPatchpointInstr(MI)) {
+        std::pair<unsigned, unsigned> NonZeroCostRange =
+            TII->getPatchpointUnfoldableRange(MI);
----------------
I was thinking of moving the whole thing in a function to be able to write something like:

```
else if (TII->hasLoadFromStackSlot(MI, Accesses) &&
             llvm::any_of(Accesses, isSpillSlotAccess)) {
  if (isX(MI, TII))
   ++Stats.ZeroCostFoldedReloads
  else
   ++Stats.FoldedReloads;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100016/new/

https://reviews.llvm.org/D100016



More information about the llvm-commits mailing list