[PATCH] D98916: [ARM] support symbolic expression as immediate in memory instructions

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 11:56:02 PDT 2021


jcai19 marked an inline comment as not done.
jcai19 added inline comments.


================
Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:3007
+        // Special case for #-0
+        if (Val == std::numeric_limits<int32_t>::min())
+          Val = 0;
----------------
peter.smith wrote:
> Looks like a few changes are just formatting (clang-format?) While it doesn't bother me personally, I have seen some people prefer that pure formatting changes are committed separately with a [NFC] tag as it minimises the diff when trying to bisect a problem. Maybe worth committing these bits first in a separate [NFC]
This was actually part of the automatic linting done by `arc diff`. It seems I I can't use it without accepting the linting?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98916/new/

https://reviews.llvm.org/D98916



More information about the llvm-commits mailing list