[PATCH] D100011: [lld-macho] Make time-trace* options more permissive.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 11:37:22 PDT 2021


oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1036-1038
+  config->timeTraceEnabled = args.hasArg(OPT_time_trace) ||
+                             args.hasArg(OPT_time_trace_granularity_eq) ||
+                             args.hasArg(OPT_time_trace_file_eq);
----------------
int3 wrote:
> int3 wrote:
> > looks like `hasArg` actually takes a varargs list, so I think this should work
> Done in https://github.com/llvm/llvm-project/commit/c2e76a9a6dcc09434d47ba9217fa02d997c2401d
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100011/new/

https://reviews.llvm.org/D100011



More information about the llvm-commits mailing list