[llvm] 4b33b23 - Reapply "[LV] Vectorize (some) early and multiple exit loops"" w/fix for builder

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 11:17:00 PDT 2021


This isn't a regression in this change, we're exposing an existing issue 
at higher frequency.  I reduced a test which doesn't involve this 
change, and filed a bug for it. https://bugs.llvm.org/show_bug.cgi?id=49900

Florian, I'm willing to take a shot at fixing this, but need a bit of 
help.  Would you have a couple minutes to debate ideas on how the 
vectorizer should be structured to avoid querying SCEV over partially 
constructed IR?

Philip

On 4/8/21 8:05 AM, Florian Hahn wrote:
> Hi Philip,
>
>> On Dec 28, 2020, at 18:15, Philip Reames via llvm-commits 
>> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>>
>>
>> Author: Philip Reames
>> Date: 2020-12-28T10:13:28-08:00
>> New Revision: 4b33b2387787aef5020450cdcc8dde231eb0a5fc
>>
>> URL: 
>> https://github.com/llvm/llvm-project/commit/4b33b2387787aef5020450cdcc8dde231eb0a5fc 
>> <https://github.com/llvm/llvm-project/commit/4b33b2387787aef5020450cdcc8dde231eb0a5fc>
>> DIFF: 
>> https://github.com/llvm/llvm-project/commit/4b33b2387787aef5020450cdcc8dde231eb0a5fc.diff 
>> <https://github.com/llvm/llvm-project/commit/4b33b2387787aef5020450cdcc8dde231eb0a5fc.diff>
>>
>> LOG: Reapply "[LV] Vectorize (some) early and multiple exit loops"" 
>> w/fix for builder
>>
>> This reverts commit 4ffcd4fe9ac2ee948948f732baa16663eb63f1c7 thus 
>> restoring e4df6a40dad.
>>
>> The only change from the original patch is to add "llvm::" before the 
>> call to empty(iterator_range).  This is a speculative fix for the 
>> ambiguity reported on some builders.
>
> It looks like the following failure started with the patch: 
> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33029 
> <https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=33029>
>
> It would be great if you could take a look.
>
> Cheers,
> Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210408/dc4060f9/attachment.html>


More information about the llvm-commits mailing list