[PATCH] D99897: Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph()

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG5f0ac1ef7888: Set IgnoreLLVMUsed to false in CallGraph::addToCallGraph() (authored by rampitec).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99897/new/

https://reviews.llvm.org/D99897

Files:
  llvm/lib/Analysis/CallGraph.cpp
  llvm/test/Analysis/CallGraph/ignore-llvm-used.ll
  llvm/test/Analysis/CallGraph/llvm-used.ll


Index: llvm/test/Analysis/CallGraph/llvm-used.ll
===================================================================
--- llvm/test/Analysis/CallGraph/llvm-used.ll
+++ llvm/test/Analysis/CallGraph/llvm-used.ll
@@ -1,12 +1,20 @@
 ; RUN: opt < %s -print-callgraph -disable-output 2>&1 | FileCheck %s
+
+; The test will report used1 and used2 functions as used on the grounds
+; of llvm.*.used references. Passing IgnoreLLVMUsed = true into the
+; Function::hasAddressTaken() in the CallGraph::addToCallGraph() has to
+; change their uses to zero.
+
 ; CHECK: Call graph node <<null function>><<{{.*}}>>  #uses=0
+; CHECK-NEXT:  CS<None> calls function 'used1'
+; CHECK-NEXT:  CS<None> calls function 'used2'
 ; CHECK-NEXT:  CS<None> calls function 'unused'
 ; CHECK-EMPTY:
 ; CHECK-NEXT:   Call graph node for function: 'unused'<<{{.*}}>>  #uses=1
 ; CHECK-EMPTY:
-; CHECK-NEXT:   Call graph node for function: 'used1'<<{{.*}}>>  #uses=0
+; CHECK-NEXT:   Call graph node for function: 'used1'<<{{.*}}>>  #uses=1
 ; CHECK-EMPTY:
-; CHECK-NEXT:   Call graph node for function: 'used2'<<{{.*}}>>  #uses=0
+; CHECK-NEXT:   Call graph node for function: 'used2'<<{{.*}}>>  #uses=1
 ; CHECK-EMPTY:
 
 @llvm.used = appending global [1 x i8*] [i8* bitcast (void ()* @used1 to i8*)]
Index: llvm/lib/Analysis/CallGraph.cpp
===================================================================
--- llvm/lib/Analysis/CallGraph.cpp
+++ llvm/lib/Analysis/CallGraph.cpp
@@ -82,7 +82,7 @@
   if (!F->hasLocalLinkage() ||
       F->hasAddressTaken(nullptr, /*IgnoreCallbackUses=*/true,
                          /* IgnoreAssumeLikeCalls */ true,
-                         /* IgnoreLLVMUsed */ true))
+                         /* IgnoreLLVMUsed */ false))
     ExternalCallingNode->addCalledFunction(nullptr, Node);
 
   populateCallGraphNode(Node);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99897.336175.patch
Type: text/x-patch
Size: 1827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210408/ff30350b/attachment.bin>