[PATCH] D100115: [RISCV] Add missing part of instruction vmsge {u}. VX
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 8 11:13:28 PDT 2021
craig.topper added a comment.
Upload patches with full context using git diff -U99999 as documented here https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2397
.addReg(RISCV::V0));
- } else if (Inst.getNumOperands() == 5) {
+ } else if (Inst.getNumOperands() == 5 && Inst.getOperand(0).getReg() == RISCV::V0) {
// masked va >= x, vd == v0
----------------
Please wrap this line as clang-format says.
================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:2416
+ } else if (Inst.getNumOperands() == 5){
+ //masked va >= x, any vd
+ //pseudoinstruction: vmsge{u}.vx vd, va, x, v0.t, vt
----------------
Please indent these comments as the clang-format says.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100115/new/
https://reviews.llvm.org/D100115
More information about the llvm-commits
mailing list