[PATCH] D100090: [CSSPGO] Fix dangling context strings and improve profile order consistency and error handling
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 8 10:19:57 PDT 2021
hoy added a comment.
Thanks for fixing the name volatileness issue which was overlooked previously.
================
Comment at: llvm/lib/ProfileData/SampleProf.cpp:385
+ assert(Ret.second && "Conext conflict during canonicalization");
+ FProfile = Ret.first->second;
+
----------------
For a profile whose key is different from the profile name string, are there other profiles merged into it, or is it merged into other profiles? A comment could be helpful.
================
Comment at: llvm/lib/ProfileData/SampleProfWriter.cpp:503
for (auto N : V) {
OS << N;
encodeULEB128(0, OS);
----------------
Can brackets be output here instead of adding it to name table and looking it up there?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100090/new/
https://reviews.llvm.org/D100090
More information about the llvm-commits
mailing list