[PATCH] D99900: [llvm] [testsuite] Fix invalid DW_AT_location DWARF expression in unattached-global.ll

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 09:43:44 PDT 2021


aprantl added a comment.

Maybe I'm missing something but it looks to me like this test is supposed to test that we don't attach DW_AT_location to a variable that has been optimized out.

This test is what you get after optimizing away

  someglobal = i32 ..., !dbg !3

and I don't think it is invalid at all. Since it doesn't hold a constant, the DIExpression is meaningless without being attached to a global, but it's not invalid IR. It just shouldn't get output in DWARF.

This going to get less ambiguous with the ongoing work to make arguments in DIExpressions more explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99900/new/

https://reviews.llvm.org/D99900



More information about the llvm-commits mailing list