[PATCH] D99905: [OPENMP51]Initial parsing/sema for adjust_args clause for 'declare variant'

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10623
+def err_omp_adjust_arg_multiple_clauses : Error<
+  "adjust_arg argument %0 used in multiple clauses">;
+def err_omp_clause_requires_dispatch_construct : Error<
----------------



================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1450-1455
+    if (!IsError) {
+      if (Data.ExtraModifier == OMPC_ADJUST_ARGS_nothing)
+        llvm::append_range(AdjustNothing, Vars);
+      else
+        llvm::append_range(AdjustNeedDevicePtr, Vars);
+    }
----------------



================
Comment at: clang/lib/Parse/ParseOpenMP.cpp:1456
+    }
+    return false;
+  }
----------------
Should this return `IsError`?


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7089-7094
+    for (TraitProperty Property : VMI.ConstructTraits)
+      if (Property == llvm::omp::TraitProperty::construct_dispatch_dispatch) {
+        Found = true;
+        break;
+      }
+    if (!Found) {
----------------



================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:7109
+    E = E->IgnoreParenImpCasts();
+    if (const auto *DRE = dyn_cast<DeclRefExpr>(E)) {
+      if (const auto *PVD = dyn_cast<ParmVarDecl>(DRE->getDecl())) {
----------------
Do we have to worry about things like `MemberExpr` as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99905/new/

https://reviews.llvm.org/D99905