[PATCH] D100082: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 09:21:18 PDT 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG3f6753efe199: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols (authored by int3).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100082/new/

https://reviews.llvm.org/D100082

Files:
  lld/test/MachO/abs-symbols.s


Index: lld/test/MachO/abs-symbols.s
===================================================================
--- lld/test/MachO/abs-symbols.s
+++ lld/test/MachO/abs-symbols.s
@@ -6,6 +6,7 @@
 # CHECK-LABEL: SYMBOL TABLE:
 # CHECK-DAG:   000000000000dead g       *ABS* _foo
 # CHECK-DAG:   000000000000beef g       *ABS* _weakfoo
+# CHECK-DAG:   000000000000cafe l       *ABS* _localfoo
 
 # CHECK-LABEL: Exports trie:
 # CHECK-DAG:   0x0000DEAD  _foo [absolute]
@@ -15,10 +16,8 @@
 .weak_definition _weakfoo
 _foo = 0xdead
 _weakfoo = 0xbeef
+_localfoo = 0xcafe
 
 .text
 _main:
   ret
-
-## TODO: once we support emitting local symbols in the symtab, test local
-## absolute symbols too


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100082.336147.patch
Type: text/x-patch
Size: 683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210408/f6c9ee94/attachment.bin>


More information about the llvm-commits mailing list