[PATCH] D99593: [Clang][RISCV] Implement vlseg builtins.

[Zakk Chen via Phabricator via llvm-commits]

khchen added inline comments.


================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:594
   auto PType = Transformer.back();
+  static unsigned NFCount = 0;
   switch (PType) {
----------------
rogfer01 wrote:
> Was this meant to be `static` here?
Maybe we can create a new complex type transformer `(Tuple:Value)`,  so `(Tuple:3)` means `TTTv`. It can avoid to use `static` here. You could ref https://github.com/llvm/llvm-project/blob/main/clang/utils/TableGen/RISCVVEmitter.cpp#L638


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99593/new/

https://reviews.llvm.org/D99593