[PATCH] D100050: [AIX] Remove unused vector registers from allocation order in the default AltiVec ABI

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 08:19:40 PDT 2021


ZarkoCA added a comment.

In D100050#2676761 <https://reviews.llvm.org/D100050#2676761>, @jsji wrote:

> What is the fundamental reason of not fixing the bug in `getReservedRegs` but doing that by changing allocation order instead ?

We had an offline discussion about this and I decided to go with this approach here for the following reasons:

1. Applying the fix in getReservedRegs //should// work, however, removing from the allocation order is technically more correct since they are not actually reserved for any use. Instead they cannot be used at all.
2. I am concerned about the different register subclasses that we can accidentally omit using the `getReservedRegs`
3. In our offline discussion we didn't come to conclusion to which approach is "better" and maybe continuing the discussion here would be good.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100050/new/

https://reviews.llvm.org/D100050



More information about the llvm-commits mailing list