[PATCH] D99377: [PowerPC] Add ROP Protection to prologue and epilogue

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. I agree that the test case is extremely verbose but this is one of those things that unfortunately has so many interactions that it has to. And producing checks with a script makes it more maintainable as well as making it easy to diagnose any failures.



================
Comment at: llvm/test/CodeGen/PowerPC/ppc64-rop-protection.ll:358
+; LE-P10-NEXT:    std r0, 16(r1)
+; LE-P10-NEXT:    hashst r0, -488(r1)
+; LE-P10-NEXT:    stw r12, 8(r1)
----------------
Please add a comment that this is technically a violation of the ABI since it is outside the red zone, but that the restriction is likely to be removed in an upcoming revision. Similar comment should go into the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99377/new/

https://reviews.llvm.org/D99377