[PATCH] D99794: libclc: Add -cl-no-stdinc to clang flags on clang >=13

Thu Apr 8 07:16:24 PDT 2021

jvesely added a comment.

In D99794#2673632 <https://reviews.llvm.org/D99794#2673632>, @Anastasia wrote:

> In D99794#2672235 <https://reviews.llvm.org/D99794#2672235>, @jvesely wrote:
>
>> In D99794#2671843 <https://reviews.llvm.org/D99794#2671843>, @Anastasia wrote:
>>
>>> Btw just out of curiosity are there any reasons for libclc not to use clang implicit headers? They support all OpenCL standards and get a lot of new features and bug fixes regularly.
>>
>> historic. libclc was ignored by most of the clang opencl work and nobody volunteered to switch it to clang provided headers.
>> Moreover, it has been stuck in clc 1.1/1.2 so most of the new features don't apply.
>> The main user is mesa/clover so that one needs to be switched to using clang implicit headers first
>
> OK, I see. Thanks for the clarification! Btw the functionality of version 1.1. and 1.2 is fairly complete in clang headers. So it should be relatively low risk if you switch to it. If there are any specific adjustments needed for //libclc// we can surely find a way to accommodate those.

Agreed. Removing the header duplication is on my todo list. it should help avoid the need for changes like D83473 <https://reviews.llvm.org/D83473> going forward.
It's not a high priority though. Integration with llvm-project cmake, and fixing `convert_*` correctness issues are higher on the list.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99794/new/

https://reviews.llvm.org/D99794