[PATCH] D99010: [X86][AMX] Hoist ldtilecfg

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:183
+          MachineBasicBlock *PhiInMBB = DefMI->getOperand(I + 1).getMBB();
+          if (!isLoopBackEdge(DefMBB, PhiInMBB))
+            WorkList.push_back(&DefMI->getOperand(I));
----------------
Better to add test case to cover the logic.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:266
+      for (auto *Succ : MBB->successors())
+        if (VistedBB.insert(Succ).second && !isLoopBackEdge(Succ, MBB))
+          WorkList.push_back(Succ);
----------------
Better to add test case for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99010/new/

https://reviews.llvm.org/D99010