[PATCH] D99490: [NFC][LoopUnswitch] Move hasPartialIVCondition to LoopUtils

JinGu Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 8 05:15:18 PDT 2021


jaykang10 added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:516
+/// the condition in the loops created for the true or false successors.
+Optional<IVConditionInfo> hasPartialIVCondition(Loop *L, unsigned MSSAThreshold,
+                                                MemorySSA *MSSA, AAResults *AA);
----------------
SjoerdMeijer wrote:
> jaykang10 wrote:
> > fhahn wrote:
> > > `L`, `MSSA` and `AA` are all needed. Can we pass them by reference?
> > Ah, let me change it on https://reviews.llvm.org/D99354. Is it ok?
> Looks like a very small change to me. If you're confident, just go ahead and commit this without review. If you want to a second opinion, we can always look at it in a review.
It has been merged to upstream. `commit cfe87d4eddfccff4b6fb09156d5645790240a8e8`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99490/new/

https://reviews.llvm.org/D99490



More information about the llvm-commits mailing list