[PATCH] D99751: Add the TableGen assert statement, step 3
Jan Svoboda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 8 04:39:08 PDT 2021
jansvoboda11 added inline comments.
================
Comment at: llvm/lib/TableGen/TGParser.cpp:3331
/// MultiClassObject ::= DefInst
-/// MultiClassObject ::= MultiClassInst
/// MultiClassObject ::= DefMInst
----------------
Paul-C-Anagnostopoulos wrote:
> jansvoboda11 wrote:
> > This patch doesn't seem to change the (supposedly) recursive nature of multiclasses. If the comment is stale, I think it would be clearer to move the change into a separate NFC commit explaining the situation.
> A separate revision just to remove an incorrect comment? Okay.
I think a trivial change like this can be committed without a Phabricator review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99751/new/
https://reviews.llvm.org/D99751
More information about the llvm-commits
mailing list