[PATCH] D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads
Serguei Katkov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 8 04:07:06 PDT 2021
skatkov added a comment.
In D100016#2675709 <https://reviews.llvm.org/D100016#2675709>, @reames wrote:
> I think you're computing slightly the wrong stat here. You're computing "instructions with at least one zero cost use". What I think you actually want is "number of zero cost uses folded". Key point is that a single instruction is likely to have many such uses, and, possibly, some non-zero cost uses.
Actually I tried to be consistent with other statistic. All other stat collect number of instructions, not number of stack slot used.
In this term I tried to collect zero cost instruction (all stack slot are zero cost uses) or just folded instructions.
I guess if we want move from number of instructions to number of stack slot usages we should do it for all other cases as well...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100016/new/
https://reviews.llvm.org/D100016
More information about the llvm-commits
mailing list