[PATCH] D99569: [LoopVectorize] Fix bug where predicated loads/stores were dropped

Thu Apr 8 03:50:23 PDT 2021

joechrisellis added a comment.

Gentle ping. 🙂

================
Comment at: llvm/test/Transforms/LoopVectorize/X86/x86-predication.ll:69
+; SINK-GATHER: pred.load.if:
+; SINK-GATHER:   %{{.*}} = load i32, i32* %{{.*}}, align 4
+; SINK-GATHER: pred.load.continue:
----------------
david-arm wrote:
> Hi @joechrisellis you've lost the variable `T0` here that was used to ensure the load fed into the udiv. It would be good if you could re-add this.
Sure, will re-add this. For context, I removed this because the control flow is now slightly different now that the loads are predicated, so I thought the cleanest thing to do would be to remove the use of this variable. I've added it back now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99569/new/

https://reviews.llvm.org/D99569