[PATCH] D97656: [llvm-objcopy] Initial XCOFF32 support.

[EsmeYi via Phabricator via llvm-commits]

Esme added a comment.

Good catch, thanks!

In D97656#2676095 <https://reviews.llvm.org/D97656#2676095>, @shchenz wrote:

> Seems the functionality of the llvm-objcopy is not right. Could you please help to check? And maybe we need to add some other tests for the file format.
>
> 1:
>
>   $ llvm-objcopy 32.o copy_nodebug.o
>   $ dump -X32 -tv copy_nodebug.o      
>   ...
>   dump: copy_nodebug.o: dump: 0654-103 Cannot read from the specified file.
>   [6]     m   0x00000000     undef     1  extern                    **Invalid Symbol Name**

I will add the support for writing symbol name to StringTable in next update, which may fix the issue.

> 2: (with DWARF info)
>
>   $llvm-dwarfdump -a copy_debug.o
>   Program aborted due to an unhandled Error:
>   The end of the file was unexpectedly encountered
>   0.      Program arguments: llvm-dwarfdump -a copy.o
>   IOT/Abort trap (core dumped)

The patch does not support reading and writing debug info. Do you think I should add it to the patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97656/new/

https://reviews.llvm.org/D97656