[PATCH] D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

In D99642#2674663 <https://reviews.llvm.org/D99642#2674663>, @fhahn wrote:

> LGTM, thanks!
>
> @nlopes do you have any more thoughts on the difference between LLVM & Alive2 on this topic?

Not yet, sorry. But it's unfair to block this patch as we don't have an ETA yet.
At most, this patch is making things more conservative, not introducing a miscompilation, and so it's ok.

The icmp in the test case can be true only if we assume that pointer comparison is equal to integer comparison. Which is something that LLVM assumes in a few places. Though it's not a consistent design choice. We are still trying to understand the pros and cons of the different solutions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99642/new/

https://reviews.llvm.org/D99642